ci: Move sidetrail docker container to other repo #3518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o install tooling ahead of time.
camshaft
approved these changes
Sep 27, 2022
goatgoose
approved these changes
Sep 29, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
#3465
Description of changes:
Our sidetrail test was already using a pre-built docker container, but strangely did not install all the tooling needed for the test. This PR moves it's building to a private docker build repository and removes installation steps that are taking place at container build time.
Call-outs:
The docker build is still using the scripts in codebuild/bin to install everything- so there is no net-new software being installed, and there is nothing preventing outside contributors from duplicating our container (this and that).
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? ad-hoc CodeBuild
Is this a refactor change? no
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.