Enforce init and cleanup calling rules (#3446) #3512
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
This fixes #3446
Description of changes:
The USAGE-GUIDE states that "... s2n_init() MUST NOT be called more than once ...".
The public documentation in s2n.h for s2n_init states that s2n_init "should only be called once".
Issue #3446 is a result of not enforcing the documented restrictions.
This pull request enforces the init-once rule, and also properly sets the internal flag
initialized
to allow the library to be re-initialized, for projects that fully control the initialization scope and re-initialize the library, for example within unit tests and fixtures.Call-outs:
Any code that has been misbehaving will start getting errors instead of undefined behavior. Previously the code did not protect against calling s2n_init midway through a program, which could have unexpected consequences.
Testing:
The s2n_init unit test was modified to ensure the calling rules are enforced and that appropriate errors are present when violated.
Licensing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.