docs: update openssl docs #3503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a3271a2
to
ae00c33
Compare
ae00c33
to
13db042
Compare
toidiu
commented
Sep 19, 2022
lrstewart
reviewed
Sep 19, 2022
197568b
to
e0bb6d5
Compare
lrstewart
reviewed
Sep 21, 2022
e0bb6d5
to
aa7657e
Compare
lrstewart
reviewed
Sep 21, 2022
lrstewart
approved these changes
Sep 26, 2022
82dccee
to
39bb775
Compare
maddeleine
approved these changes
Sep 27, 2022
39bb775
to
5277986
Compare
5277986
to
7a63cdf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Update docs to include openssl 3 support and consolidate openssl install instructions.
Originally I wanted to describe each flag.. but then we are documenting openssl features. I instead wanted to link to openssl documentation.. but couldn't find any.
Instead I opted to explain the reason for calling
./configwith flags (disable openssl features), which is an improvement to the current docs.Callout:
There is no longer a single script than one can copy and paste. Instead a user would need to piece together a few scripts. I would argue this is probably a good thing since it forces the user to read and reason about the config options.
Is this a refactor change? If so, how have you proved that the intended behavior hasn't changed?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.