Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for verify after sign with invalid signature #3486

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

lrstewart
Copy link
Contributor

@lrstewart lrstewart commented Sep 13, 2022

Description of changes:

Add the missing test for #3482. Of course as soon as I merged it I realized how it could be tested -_- I modify the pkey "sign" operation to force a bad signature.

Testing:

This is a new test.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the s2n-core team label Sep 13, 2022
@lrstewart lrstewart marked this pull request as ready for review September 13, 2022 17:34
@lrstewart lrstewart requested a review from a team as a code owner September 13, 2022 17:34
Copy link
Contributor

@camshaft camshaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

Copy link
Contributor

@goatgoose goatgoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@lrstewart lrstewart enabled auto-merge (squash) September 13, 2022 17:45
@lrstewart lrstewart merged commit e820b58 into aws:main Sep 13, 2022
@lrstewart lrstewart deleted the verify branch September 13, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants