Add compliance comments for secure renegotiation initial handshakes #3485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddeleine
reviewed
Sep 13, 2022
| size_t client_hello_size = server_conn->client_hello.raw_message.size; | ||
| size_t old_extensions_size = server_conn->client_hello.extensions.raw.size; | ||
| size_t new_extensions_size = old_extensions_size + sizeof(extension); | ||
| EXPECT_SUCCESS(s2n_stuffer_rewrite(&client_conn->handshake.io)); |
There was a problem hiding this comment.
I feel like we need a test function that can write custom extensions for us. Not really sure how that would work, but this is something that would be really useful.
maddeleine
reviewed
Sep 13, 2022
maddeleine
approved these changes
Sep 13, 2022
camshaft
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
I didn't make any functional changes. I just added compliance comments for sections 3.4 and 3.6 of the secure renegotiation RFC, which describe how a TLS implementation should handle non-renegotiation handshakes. Since we don't support actually doing renegotiation, we only deal with non-renegotiation handshakes.
The duvet github action we borrow from s2n-quic isn't working (it assumes PRs are from branches, not from forks), so I manually uploaded the report:
Callouts
All the "compliance/specs/tools.ietf.org/rfc/*" files are automatically generated by running
duvet extract. If they're too distracting, I can move them to a separate PR. "compliance/specs/exceptions/rfc5746/4.6.toml" wasn't generated though, and is instead our project's first duvet exceptions.Testing:
New tests for requirements not previously explicitly covered.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.