chore: upgrade to @types/node 10.x #894
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually upgrade the
node
engine support to 10.x tree, as hasbeen declared in the
package.json
files for a month now.Additionally, standardized the
compilerOptions
in thetsconfig.json
filesthat are not generated by
jsii
, in order to useES2018
standard library,enable
strict
mode (this includesstrictPropertyInitialization
, which was notenabled previously and required a few code changes in
jsii-pacmak
that weremade ad-minima).
The library clause of
tsconfig.json
files that are generated byjsii
has notbeen changed yet. This means you need to use
node >= 10.x
in order to usejsii
, but you cannot use it to build code that depend on APIs that are not yetavailable in
node 8
. This behavior will be updated in a second phase.Fixes #794
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.