Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python: verify distribution tarballs with twine check #710

Closed
eladb opened this issue Aug 14, 2019 · 0 comments · Fixed by #711
Closed

python: verify distribution tarballs with twine check #710

eladb opened this issue Aug 14, 2019 · 0 comments · Fixed by #711
Assignees
@garnaat
Labels
feature-request A feature should be added or improved. language/python Related to Python bindings

Comments

@eladb
Copy link
Contributor

eladb commented Aug 14, 2019

To avoid cases like #708, we should execute twine check on the resulting .tar.gz files produced for python. This would have discovered the issue.
@eladb eladb added language/python Related to Python bindings feature-request A feature should be added or improved. coverage labels Aug 14, 2019
RomainMuller added a commit that referenced this issue Aug 14, 2019
@RomainMuller
feat(python): check distribution artifacts with twine`
ca1c06a 
Adds a `twine check` invocation at the end of building the distribution
artifacts for PyPI, in order to ensure the produced bundles will render
propertly on PyPI, and be valid artifacts.

This particularly guards against "tool old" versions of `setuptools`,
but could also catch certain other issues.

Fixes #710
RomainMuller added a commit that referenced this issue Aug 14, 2019
@RomainMuller
feat(python): check distribution artifacts with twine
56abba8 
Adds a `twine check` invocation at the end of building the distribution
artifacts for PyPI, in order to ensure the produced bundles will render
propertly on PyPI, and be valid artifacts.

This particularly guards against "tool old" versions of `setuptools`,
but could also catch certain other issues.

Fixes #710
@RomainMuller RomainMuller mentioned this issue Aug 14, 2019
Merged
@mergify mergify bot closed this as completed in #711 Aug 14, 2019
mergify bot pushed a commit that referenced this issue Aug 14, 2019
@RomainMuller @mergify
feat(python): check distribution artifacts with twine (#711)
f3d1da0 
Adds a `twine check` invocation at the end of building the distribution
artifacts for PyPI, in order to ensure the produced bundles will render
propertly on PyPI, and be valid artifacts.

This particularly guards against "tool old" versions of `setuptools`,
but could also catch certain other issues.

Fixes #710
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garnaat garnaat

Labels
feature-request A feature should be added or improved. language/python Related to Python bindings
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(python): check distribution artifacts with twine aws/jsii
2 participants
@garnaat @eladb