Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsii-pacmak: very eager to detect Maven repositories #447

Closed
rix0rrr opened this issue Apr 11, 2019 · 1 comment
Closed

jsii-pacmak: very eager to detect Maven repositories #447

rix0rrr opened this issue Apr 11, 2019 · 1 comment
Labels
bug This issue is a bug.

Comments

@rix0rrr
Copy link
Contributor

rix0rrr commented Apr 11, 2019

Don't know exactly what's going on, but jsii-pacmak is doing a lot of duplicate work. When run with -v:

@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/cx-api/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/aws-events/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/aws-iam/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/cdk/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/cx-api/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/region-info/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/cdk/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/cx-api/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/aws-iam/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/cdk/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/cx-api/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/region-info/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/aws-logs/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/aws-cloudwatch/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/aws-iam/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/cdk/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/cx-api/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/region-info/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/cdk/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/cx-api/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/aws-iam/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/cdk/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/cx-api/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/region-info/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/cdk/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/cx-api/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/aws-s3/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/aws-events/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/aws-iam/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/cdk/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/cx-api/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/region-info/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/cdk/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/cx-api/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/aws-iam/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/cdk/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/cx-api/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/region-info/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/aws-kms/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/aws-iam/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/cdk/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/cx-api/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/region-info/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/cdk/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/cx-api/dist/java as a local dependency output 
@aws-cdk/aws-codepipeline-actions: [jsii-pacmak] [VERBOSE] Found /codebuild/output/src173406332/src/packages/@aws-cdk/aws-s3-notifications/dist/java as a local dependency output
@rix0rrr rix0rrr added the bug This issue is a bug. label Apr 11, 2019
@rix0rrr
Copy link
Contributor Author

rix0rrr commented Apr 11, 2019

Fairly sure this is the reason why the build hangs.

The build ends with:

@aws-cdk/app-delivery:   '/codebuild/output/src173406332/src/packages/@aws-cdk/aws-kms/dist/java', 
@aws-cdk/app-delivery:   '/codebuild/output/src173406332/src/packages/@aws-cdk/aws-iam/dist/java', 
@aws-cdk/app-delivery:   '/codebuild/output/src173406332/src/packages/@aws-cdk/cdk/dist/java', 
@aws-cdk/app-delivery:   ... 6281 more items ] 
@aws-cdk/app-delivery: [jsii-pacmak] [VERBOSE] Generated /tmp/jsii-pacmak-code6J4idX/user.xml 
@aws-cdk/app-delivery: [INFO] Scanning for projects...

Maven is now scanning 6000+ directories for the same project every time.

rix0rrr pushed a commit that referenced this issue Apr 11, 2019
fix(pacmak): fix Maven dependency collector.
78e941f 
Stop the Maven dependency collector from recursing into directories it's
already seen. This avoids finding adding the same directories over and
over again, which Maven subsequently can't deal with.

Fixes #447, and probably the hanging build.
@rix0rrr rix0rrr mentioned this issue Apr 11, 2019
Merged
rix0rrr added a commit that referenced this issue Apr 11, 2019
@rix0rrr
fix(pacmak): fix Maven dependency collector. (#449)
675b86a 
Stop the Maven dependency collector from recursing into directories it's
already seen. This avoids finding adding the same directories over and
over again, which Maven subsequently can't deal with.

Fixes #447, and probably the hanging build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rix0rrr