-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSII doesnt genereate nullable enum in .Net #414
Labels
Comments
Same problem with SslPolicy in ApplicationListenerProps
|
RomainMuller
added a commit
that referenced
this issue
Apr 4, 2019
Method `Parameters` now carry an `optional` flag that indicates whether they are optional or required, and the `TypeReference#optional` field was renamed to `TypeReference#nullable` to better reflect its semantics. This also brings more flexibility in that it is now possible to model a method with a nullable or defaulted argument that is followed by some non-optional argument, and still obtain a reasonable type specification, where previously this was an error. Finally, in order to better reflect the type model of TypeScript and Javascript, all `any` type references are now denoted `nullable`. BREAKING CHANGE: JSII assemblies generated by older versions of the tool will fail loading with this new version, and vice-versa. Re-compile your projects in order to fix this. Fixes #296 Fixes #414
@RomainMuller – I moved this from the CDK board to the (new) .NET board. It sounds like there's .NET specific work after the jsii core work? |
Well. There was an issue in the .Net code generator that I have fixed as part of my work in #432. Once this ships, this bug should be gone. |
RomainMuller
added a commit
that referenced
this issue
Apr 10, 2019
Method `Parameters`, `Properties` and method return types now carry an `optional` flag that indicates whether they are optional or required, and the `TypeReference#optional` field was removed. BREAKING CHANGE: JSII assemblies generated by older versions of the tool will fail loading with this new version, and vice-versa. Re-compile your projects in order to fix this. Fixes #296 Fixes #414
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
The following code in the .net CDK
doesnt follow the nullability in vpc-ref.ts
Which makes .Net code throw
Only one of subnetType and subnetName can be supplied
everytime a SubnetName is used, even if no value is defined for SubnetTypehttps://github.com/awslabs/aws-cdk/blob/master/packages/@aws-cdk/aws-ec2/lib/vpc-ref.ts
The text was updated successfully, but these errors were encountered: