Pull in latest X-Ray SDK version in distribution test #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added sample apps code
wangzlei
reviewed
May 11, 2022
| @@ -1,7 +1,7 @@ | |||
| module distributioncheck | |||
|
|
|||
| require ( | |||
| github.com/aws/aws-xray-sdk-go v1.6.0 | |||
| github.com/aws/aws-xray-sdk-go latest | |||
There was a problem hiding this comment.
Question: is this to pull the latest tag or the master repo?
There was a problem hiding this comment.
latest released tag always.
wangzlei
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Currently distribution check test does not pull in the latest version of X-Ray Go SDK. It pulls the version mentioned in the
go.modfile so that when we release the new version, we have to update thego.modfile manually to the latest version in order to run distribution test against the latest version.Description of changes:
This change always pulls in the latest released version of X-Ray Go SDK in distribution check so no need to update it.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.