S3crypto client #760
Merged
S3crypto client #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xibz
commented
Jul 18, 2016
•
xibz
commented
- Write more documentation
- Add more tests
- Move integration test to own package
| @@ -0,0 +1,18 @@ | |||
| # language: en | |||
| @s3 @client | |||
There was a problem hiding this comment.
@s3 probably should be something like @s3encclient to be specific to these integration tests. @client is generally reserved for the generated service client too.
…n not finding envelope
xibz
force-pushed
the
crypto_client_clean
branch
from
b68878c
to
700eb73
Compare
|
|
jasdel
added a commit
that referenced
this pull request
Aug 10, 2016
skotambkar
added a commit
to skotambkar/aws-sdk-go
that referenced
this pull request
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.