Loosen Operation Existence during Model Loading #4804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syall
commented
Apr 18, 2023
| @@ -173,6 +173,7 @@ func (a *API) APISmokeTestsGoCode() string { | |||
| var smokeTestTmpl = template.Must(template.New(`smokeTestTmpl`).Parse(` | |||
| {{- range $i, $testCase := $.TestCases }} | |||
| {{- $op := index $.API.Operations $testCase.OpName }} | |||
| {{- if $op }} | |||
There was a problem hiding this comment.
I'm not familiar with go templates, but this path should only get triggered if $op is truthy (in this case, not nil).
There was a problem hiding this comment.
Would appear correct according to https://pkg.go.dev/text/template#hdr-Actions
lucix-aws
approved these changes
Apr 18, 2023
aajtodd
approved these changes
Apr 19, 2023
| @@ -173,6 +173,7 @@ func (a *API) APISmokeTestsGoCode() string { | |||
| var smokeTestTmpl = template.Must(template.New(`smokeTestTmpl`).Parse(` | |||
| {{- range $i, $testCase := $.TestCases }} | |||
| {{- $op := index $.API.Operations $testCase.OpName }} | |||
| {{- if $op }} | |||
There was a problem hiding this comment.
Would appear correct according to https://pkg.go.dev/text/template#hdr-Actions
syall
force-pushed
the
loosen-operation-existence-model-loading
branch
from
906c507
to
ff97bd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For changes to files under the
/model/folder, and manual edits to autogenerated code (e.g./service/s3/api.go) please create an Issue instead of a PR for those type of changes.N/A.
If there is an existing bug or feature this PR is answers please reference it here.
N/A.
aws-sdk-godoesn't support document types, so they are removed from the API JSON models upstream (and anything that references it, i.e. structures and even operations).Paginators do not have the same upstream removal process, so there could be "orphaned" operations. This change loosens restrictions when loading paginators, waiters, and smoke tests when an operation cannot be found in the API JSON model.
Loosen operation existence during model loading so generation won't fail when operations don't exist in the model: