codegen: Limit SDKs API payload ignoring trait to unmodeled request inputs #4139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the SDK's protocol serialization code generation to only ignore request API payloads for operations without modeled payload input parameters. The SDKs protocol deserializers did not correctly handle this value and caused unexpected close_wait states on the HTTP connection because the response body was not drained.
skotambkar
approved these changes
Oct 20, 2021
skmcgrail
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the SDK's protocol serialization code generation to only ignore request API payloads for operations without modeled payload input parameters. The SDKs protocol deserializers did not correctly handle this value and caused unexpected close_wait states on the HTTP connection because the response body was not drained.