Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws/session: Enable SSO provider to be mixed with other credential providers #3905

Merged
merged 2 commits into from
May 18, 2021

Conversation

skmcgrail
Copy link
Member

Enables SSO credential provider configuration to be mixed with other credential providers.

Fixes: #3763

@skmcgrail skmcgrail force-pushed the ssoSharedConfig branch 2 times, most recently from fb7391e to bcc230b Compare May 12, 2021 21:59
aws/session/credentials_test.go Outdated Show resolved Hide resolved
aws/session/credentials_test.go Outdated Show resolved Hide resolved
@skmcgrail skmcgrail merged commit 59ed94a into aws:main May 18, 2021
@skmcgrail skmcgrail deleted the ssoSharedConfig branch May 18, 2021 16:29
aws-sdk-go-automation pushed a commit that referenced this pull request May 18, 2021
===

### Service Client Updates
* `service/apprunner`: Updates service API, documentation, paginators, and examples
* `service/compute-optimizer`: Updates service API and documentation
* `service/iotsitewise`: Updates service documentation
* `service/license-manager`: Updates service API and documentation
* `service/models.lex.v2`: Updates service API, documentation, and paginators
* `service/personalize`: Updates service API and documentation
* `service/support`: Updates service documentation
  * Documentation updates for support

### SDK Enhancements
* `aws/session`: Enable SSO provider to be mixed with other credential providers ([#3905](#3905))
  * Fixes [#3763](#3763)
aws-sdk-go-automation added a commit that referenced this pull request May 18, 2021
Release v1.38.42 (2021-05-18)
===

### Service Client Updates
* `service/apprunner`: Updates service API, documentation, paginators, and examples
* `service/compute-optimizer`: Updates service API and documentation
* `service/iotsitewise`: Updates service documentation
* `service/license-manager`: Updates service API and documentation
* `service/models.lex.v2`: Updates service API, documentation, and paginators
* `service/personalize`: Updates service API and documentation
* `service/support`: Updates service documentation
  * Documentation updates for support

### SDK Enhancements
* `aws/session`: Enable SSO provider to be mixed with other credential providers ([#3905](#3905))
  * Fixes [#3763](#3763)
@jorhett
Copy link

jorhett commented Nov 15, 2023

This didn't fix the underlying problem. It still rejects a valid and RECOMMENDED configuration of having both the sso_ options and credential_process as a backup for clients which won't use the sso_ options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The behavior of validateCredentialType is too strict and doesn't align with the AWS CLI or other SDKs
4 participants