Fix: Only Validate SSO profile configuration when attempting to use SSO credentials #3769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasdel
approved these changes
Feb 1, 2021
skotambkar
reviewed
Feb 1, 2021
skotambkar
approved these changes
Feb 1, 2021
aws-sdk-go-automation
pushed a commit
that referenced
this pull request
Feb 2, 2021
=== ### Service Client Updates * `service/application-autoscaling`: Updates service API and documentation * `service/appmesh`: Updates service API and documentation * `service/iotwireless`: Updates service API and documentation * `service/location`: Updates service documentation * `service/lookoutvision`: Updates service API and documentation * `service/medialive`: Updates service API and documentation * AWS Elemental MediaLive now supports Image Media Playlists on HLS outputs, version 0.4 (trick-mode). * `service/organizations`: Updates service documentation * Documentation updates for AWS Organizations. * `service/rds-data`: Updates service API and documentation * `service/route53`: Updates service documentation * Documentation updates for Route 53 * `service/s3control`: Updates service API and documentation * Amazon S3 Batch Operations now supports Delete Object Tagging ### SDK Enhancements * `service/s3`: Amazon S3 now supports AWS PrivateLink, providing direct access to S3 via a private endpoint within your virtual private network. ### SDK Bugs * `aws/session`: Fixed a bug that prevented credentials from being sourced from the environment if the loaded shared config profile contained partial SSO configuration. ([#3769](#3769)) * Fixes ([#3768](#3768))
Merged
aws-sdk-go-automation
added a commit
that referenced
this pull request
Feb 2, 2021
Release v1.37.2 (2021-02-02) === ### Service Client Updates * `service/application-autoscaling`: Updates service API and documentation * `service/appmesh`: Updates service API and documentation * `service/iotwireless`: Updates service API and documentation * `service/location`: Updates service documentation * `service/lookoutvision`: Updates service API and documentation * `service/medialive`: Updates service API and documentation * AWS Elemental MediaLive now supports Image Media Playlists on HLS outputs, version 0.4 (trick-mode). * `service/organizations`: Updates service documentation * Documentation updates for AWS Organizations. * `service/rds-data`: Updates service API and documentation * `service/route53`: Updates service documentation * Documentation updates for Route 53 * `service/s3control`: Updates service API and documentation * Amazon S3 Batch Operations now supports Delete Object Tagging ### SDK Enhancements * `service/s3`: Amazon S3 now supports AWS PrivateLink, providing direct access to S3 via a private endpoint within your virtual private network. ### SDK Bugs * `aws/session`: Fixed a bug that prevented credentials from being sourced from the environment if the loaded shared config profile contained partial SSO configuration. ([#3769](#3769)) * Fixes ([#3768](#3768))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug that prevented credentials from being sourced from the environment if the loaded shared config profile contained partial SSO configuration.
This change ensures that a profile's SSO configuration is only validated if the SSO provider were to be used.
Fixes: #3768