codegen: Ensure API structs don't collide with API client type name #3651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skotambkar
approved these changes
Nov 23, 2020
Updates the SDK's code generation to renames structures that collide with the service's API client struct name. For example, service Foo, has struct shape named Foo. The API client type would be generated as Foo, and the colliding struct shape would be renamed to Foo_, with a trailing underscore(_).
jasdel
force-pushed
the
codege/FixupCollisions
branch
from
10774cf
to
4668b09
Compare
skmcgrail
approved these changes
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the SDK's code generation to renames structures that collide with the service's API client struct name.
For example, service Foo, has struct shape named Foo. The API client type would be generated as Foo, and the colliding struct shape would be renamed to
Foo_, with a trailing underscore(_).