private/model/api: Generate enum shape functions to retrieve all values #3447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasdel
suggested changes
Aug 6, 2020
There was a problem hiding this comment.
Thanks for taking the time to create this PR @bflad. The codegeneration change looks good, but in order to ensure this doesn't have conflicts in the future i think we'll have to go down the route of EnumType_Values naming for this utility. If an API ever modeled an enum member named Values then the idiomatic generation pattern would conflict.
|
Will also want to rebase, but we can update that too before merge, so you don't have to worry about chasing the SDK's API updates. |
bflad
force-pushed
the
f-enum-values-funcs
branch
from
b26f08b
to
ad72e27
Compare
|
Switched to |
bflad
force-pushed
the
f-enum-values-funcs
branch
2 times, most recently
from
bcb40de
to
8b3f250
Compare
jasdel
force-pushed
the
f-enum-values-funcs
branch
2 times, most recently
from
42df8e0
to
c80db5d
Compare
jasdel
approved these changes
Aug 10, 2020
jasdel
force-pushed
the
f-enum-values-funcs
branch
from
c80db5d
to
e02d571
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3441
Allows consumers to easily retrieve all values of an enumeration shape.
Maintainer note: Happy to change this to the non-idiomatic
_Values()naming if desired.