Generate enum types with Contains() and Values() receiver methods #3442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference: aws#3441 Allows consumers to easily handle operations with all elements of API enumeration types.
|
It seems like this would really want some shared type(s) to handle the common logic, but rather than guess at that particular implementation, will close this in preference of discussion in the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3441
Proof of concept implementation to allow consumers to easily handle operations with all elements of API enumeration types. If this is an acceptable direction, please let me know if this needs testing or other changes, otherwise more than happy to have this closed in preference of a different implementation. 馃槃