internal/ini: Fix ini parser to handle empty values #2860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the failing Go 1.7 test is fixed in PR #2841 once that pr is merged should be able to rebase and rerun tests |
skmcgrail
approved these changes
Sep 27, 2019
b8f048b
to
20c815f
Compare
20c815f
to
fbe7c7c
Compare
Ensure HTTP servers are cleaned up during testing after no longer needed. This was creating excessive noise in testing stack traces due to the number of background goroutines active. Also updated SDK's unit tests to use verbose logging, have shorter runtime, and have a timeout fo 5m. Related to aws#2840
1dc49a0
to
a681c05
Compare
a681c05
to
fc55aa5
Compare
skmcgrail
approved these changes
Oct 1, 2019
jasdel
approved these changes
Oct 1, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ini parser incorrectly decided whether a statement should be skipped. As a result, valid statements in the ini files were being squashed. The PR fixes incorrect modifications to the previous token value of the skipper. We also add checks for cases where a skipped statement should be marked as complete and not be ignored.
Adds test cases for cases for statements that need to be skipped. Also adds suggested tests from #2801 . Fixes #2800