aws/request: Fix SDK error checking when seeking readers #2696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skotambkar
reviewed
Jul 18, 2019
670f8e6
to
123cf7b
Compare
skotambkar
reviewed
Jul 18, 2019
aws/request/request_test.go
Outdated
| @@ -1111,6 +1111,43 @@ func TestRequestNoConnection(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestRequetBodySeekFails(t *testing.T) { | |||
There was a problem hiding this comment.
nit: spelling for TestRequestBodySeekFails
skotambkar
reviewed
Jul 18, 2019
skotambkar
reviewed
Jul 18, 2019
skotambkar
reviewed
Jul 19, 2019
skotambkar
approved these changes
Jul 19, 2019
Fixes the SDK handling of seeking a reader to ensure errors are not lost, and are bubbled up. In several places the SDK ignored Seek errors when attempting to determine a reader's length, or rewinding the reader for retry attempts. Related to aws#2525
123cf7b
to
2c36c8e
Compare
jasdel
added a commit
that referenced
this pull request
Jul 22, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the SDK handling of seeking a reader to ensure errors are not
lost, and are bubbled up.
In several places the SDK ignored Seek errors when attempting to
determine a reader's length, or rewinding the reader for retry attempts.
Related to #2525