Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set test data to conform to internal scanners format #2735

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

Madrigal
Copy link
Contributor

@Madrigal Madrigal commented Aug 6, 2024

We have an internal scanner picking this up as hardcoded credentials. Modifying this to confirm to the blessed string.

For changes to files under the /codegen/aws-models folder, and manual edits to autogenerated code (e.g. /service/s3/api.go) please create an Issue instead of a PR for those type of changes.

If the PR addresses an existing bug or feature, please reference it here.

To help speed up the process and reduce the time to merge please ensure that Allow edits by maintainers is checked before submitting your PR. This will allow the project maintainers to make minor adjustments or improvements to the submitted PR, allow us to reduce the roundtrip time for merging your request.

@Madrigal Madrigal requested a review from a team as a code owner August 6, 2024 17:41
@lucix-aws
Copy link
Contributor

changelog

@Madrigal Madrigal merged commit 5f159bb into main Aug 6, 2024
12 checks passed
@Madrigal Madrigal deleted the fix-sample-credentials-data-regex branch August 6, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants