Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pkgconfig files on windows #1839

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix pkgconfig files on windows #1839

wants to merge 2 commits into from

Commits on Jan 9, 2022

  1. build: Fix libdir in pkgconfig files for Windows 

    Windows import libraries are installed inside ARCHIVE_DIRECTORY, not
LIBRARY_DIRECTORY. So we need to use that for libdir on Windows.

Related to amzn/amazon-s3-gst-plugin#13
    @nirbheek
    nirbheek committed Jan 9, 2022
    Configuration menu
    Copy the full SHA
    8a1cf0d View commit details
    Browse the repository at this point in the history

  2. build: Set -DUSE_IMPORT_EXPORT in pkgconfig files on Windows 

    MSVC consumers of the shared library need to define this macro when
linking to aws-cpp-sdk-* libs, or they will get undefined reference
errors. Also doesn't hurt to define this with MinGW, so add it
unconditionally on Windows.

Related to amzn/amazon-s3-gst-plugin#13
    @nirbheek
    nirbheek committed Jan 9, 2022
    Configuration menu
    Copy the full SHA
    e901445 View commit details
    Browse the repository at this point in the history