Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BuildImage] Support build image in ADC and private networks #6290

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

hgreebe
Copy link
Contributor

@hgreebe hgreebe commented Jun 14, 2024

Description of changes

  • Support build image in ADC and private networks

Tests

  • Createami integration test
  • Ran build-image command on a instance with no internet connection.

References

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@@ -269,7 +280,7 @@ phases:
set -v
echo "Calling chef-client with /etc/parallelcluster/image_dna.json"
cat /etc/parallelcluster/image_dna.json
cinc-client --local-mode --config /etc/chef/client.rb --log_level info --force-formatter --no-color --chef-zero-port 8889 --json-attributes /etc/parallelcluster/image_dna.json --override-runlist aws-parallelcluster-entrypoints::install
cinc-client --local-mode --config /etc/chef/client.rb --log_level debug --force-formatter --no-color --chef-zero-port 8889 --json-attributes /etc/parallelcluster/image_dna.json --override-runlist aws-parallelcluster-entrypoints::install
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why debug?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had it on debug for ADC reasons but I have now switched it back to info

hanwen-pcluste
hanwen-pcluste previously approved these changes Jun 14, 2024
@hgreebe hgreebe enabled auto-merge (squash) June 14, 2024 16:44
@hgreebe hgreebe merged commit 75e7045 into aws:develop Jun 14, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants