Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Support to Suppress Validators in Custom Resources #6253

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

himani2411
Copy link
Contributor

@himani2411 himani2411 commented May 23, 2024

Description of changes

  • Adding Support to suppress validators in Custom Resources

Tests

  • Integ Test
{%- import 'common.jinja2' as common with context -%}
---
test-suites:
 custom_resource:
   test_cluster_custom_resource.py::test_cluster_create:
     dimensions:
       - oss: ["alinux2"]
         regions: ["us-east-1"]
         instances: {{ common.INSTANCES_DEFAULT_X86 }}
   test_cluster_custom_resource.py::test_cluster_create_invalid:
     dimensions:
       - oss: ["alinux2"]
         regions: ["us-east-1"]
         instances: {{ common.INSTANCES_DEFAULT_X86 }}
   test_cluster_custom_resource.py::test_cluster_update:
     dimensions:
       - oss: ["rocky8"]
         regions: ["us-east-1"]
         instances: {{ common.INSTANCES_DEFAULT_X86 }}
   test_cluster_custom_resource.py::test_cluster_update_invalid:
     dimensions:
       - oss: ["alinux2"]
         regions: ["us-east-1"]
         instances: {{ common.INSTANCES_DEFAULT_X86 }}
   test_cluster_custom_resource.py::test_cluster_update_tag_propagation:
     dimensions:
       - oss: [ "ubuntu2004" ]
         regions: ["us-east-1"]
         instances: {{ common.INSTANCES_DEFAULT_X86 }}
   test_cluster_custom_resource.py::test_cluster_delete_out_of_band:
     dimensions:
       - oss: ["ubuntu2204"]
         regions: ["us-east-1"]
         instances: {{ common.INSTANCES_DEFAULT_X86 }}
   test_cluster_custom_resource.py::test_cluster_delete_retain:
     dimensions:
       - oss: ["rocky9"]
         regions: ["us-east-1"]
         instances: {{ common.INSTANCES_DEFAULT_X86 }}
   test_cluster_custom_resource.py::test_cluster_create_with_custom_policies:
     dimensions:
       - oss: ["rhel8"]
         regions: ["us-east-1"]
         instances: {{ common.INSTANCES_DEFAULT_X86 }}


References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@himani2411 himani2411 added skip-changelog-update Disables the check that enforces changelog updates in PRs 3.x labels May 23, 2024
@himani2411 himani2411 requested review from a team as code owners May 23, 2024 14:17
@himani2411 himani2411 marked this pull request as draft May 23, 2024 14:18
@himani2411 himani2411 force-pushed the wip/custom-resource branch 2 times, most recently from 1f45e75 to cd227fd Compare May 23, 2024 15:00
@himani2411 himani2411 marked this pull request as ready for review May 29, 2024 08:12
@himani2411 himani2411 changed the title [DRAFT] Adding Support to Suppress Validators in Custom Resources Adding Support to Suppress Validators in Custom Resources May 29, 2024
@himani2411 himani2411 force-pushed the wip/custom-resource branch 3 times, most recently from a1a2cd5 to 15ebef7 Compare June 4, 2024 16:07
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.22%. Comparing base (443e33d) to head (15ebef7).
Report is 16 commits behind head on develop.

Current head 15ebef7 differs from pull request most recent head c6e4511

Please upload reports for the commit c6e4511 to get more accurate results.

Files Patch % Lines
cli/src/pcluster/lib/lib.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6253      +/-   ##
===========================================
- Coverage    90.23%   90.22%   -0.01%     
===========================================
  Files          181      181              
  Lines        15874    15875       +1     
===========================================
  Hits         14324    14324              
- Misses        1550     1551       +1     
Flag Coverage Δ
unittests 90.22% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@himani2411 himani2411 force-pushed the wip/custom-resource branch 2 times, most recently from 4657d11 to a02e8de Compare June 4, 2024 23:26
@himani2411 himani2411 force-pushed the wip/custom-resource branch 2 times, most recently from a0e8758 to 57fea30 Compare June 5, 2024 20:34
@himani2411 himani2411 force-pushed the wip/custom-resource branch 9 times, most recently from 536fcc6 to 16f5de0 Compare June 7, 2024 16:12
* Update Integ test for suppressing a Validation message
@himani2411 himani2411 merged commit b8ee7bc into aws:develop Jun 7, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x skip-changelog-update Disables the check that enforces changelog updates in PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants