Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom tags at queue level #5158

Merged
merged 2 commits into from
Apr 9, 2023

Conversation

chenwany
Copy link
Contributor

@chenwany chenwany commented Apr 5, 2023

Description of changes

  • Add support for Tags section under queue level.
Scheduling:
  Scheduler: slurm
  SlurmQueues:
    - Name: compute
      Tags:
        - Key: mytag1
          Value: myvalue1
  • The tags section under queue level support queue update strategy

Tests

  • Unit tests
  • Manually test

References

  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch and add a label in the PR title (i.e. 2.x vs 3.x)
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chenwany chenwany force-pushed the add_custom_tags branch 4 times, most recently from 4dcfc47 to f6b3a88 Compare April 6, 2023 18:55
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #5158 (8208044) into develop (0780514) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #5158      +/-   ##
===========================================
+ Coverage    89.59%   89.61%   +0.02%     
===========================================
  Files          174      175       +1     
  Lines        15051    15085      +34     
===========================================
+ Hits         13485    13519      +34     
  Misses        1566     1566              
Impacted Files Coverage Δ
cli/src/pcluster/config/cluster_config.py 95.54% <100.00%> (+0.02%) ⬆️
cli/src/pcluster/schemas/cluster_schema.py 98.78% <100.00%> (+0.01%) ⬆️
cli/src/pcluster/templates/cdk_builder_utils.py 96.80% <100.00%> (ø)
cli/src/pcluster/templates/queue_group_stack.py 98.64% <100.00%> (+0.09%) ⬆️
cli/src/pcluster/validators/tags_validators.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@davprat davprat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants