Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add s3 integration tests using directory buckets #8795

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

hssyoo
Copy link
Contributor

@hssyoo hssyoo commented Jul 11, 2024

Set up S3 directory bucket creation/teardown for integration tests with high-level s3 commands. For the existing teardown logic to be compatible with directory buckets, we switch from ListObjects to ListObjectsV2 when clearing out test buckets.

@hssyoo hssyoo requested a review from a team July 11, 2024 20:08
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 0.08%. Comparing base (489efff) to head (f67b9ec).
Report is 45 commits behind head on develop.

Files Patch % Lines
awscli/testutils.py 0.00% 26 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #8795      +/-   ##
==========================================
- Coverage     0.08%   0.08%   -0.01%     
==========================================
  Files          210     210              
  Lines        16908   16933      +25     
==========================================
  Hits            14      14              
- Misses       16894   16919      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kdaily kdaily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, a couple minor things. just around some naming consistency.

tests/integration/customizations/s3/test_plugin.py Outdated Show resolved Hide resolved
tests/integration/customizations/s3/test_plugin.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants