Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start testing on 3.13 beta build #8688

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Start testing on 3.13 beta build #8688

wants to merge 1 commit into from

Conversation

nateprewitt
Copy link
Member

This PR will start provisional testing on the recently released beta for Python 3.13. This will be used to catch any issues early before the official release in October.

@nateprewitt
Copy link
Member Author

We have one set of tests failing for the Cloudformation ArtifactExporter. It's expecting an absolute path for a parent directory but the value in 3.13 is currently \. It likely should be a fully qualified drive (i.e. C:\) to represent the top-level but we'll need to see what the value is on 3.12. This appears to only impact Windows tests.

Failing Tests

FAILED unit\customizations\cloudformation\test_artifact_exporter.py::TestArtifactExporter::test_template_export - ValueError: parent_dir parameter must be an absolute path to a folder \
FAILED unit\customizations\cloudformation\test_artifact_exporter.py::TestArtifactExporter::test_template_export_foreach_invalid - ValueError: parent_dir parameter must be an absolute path to a folder \
FAILED unit\customizations\cloudformation\test_artifact_exporter.py::TestArtifactExporter::test_template_export_foreach_valid - ValueError: parent_dir parameter must be an absolute path to a folder \
FAILED unit\customizations\cloudformation\test_artifact_exporter.py::TestArtifactExporter::test_template_export_metadata - ValueError: parent_dir parameter must be an absolute path to a folder \
FAILED unit\customizations\cloudformation\test_artifact_exporter.py::TestArtifactExporter::test_template_global_export - ValueError: parent_dir parameter must be an absolute path to a folder \

Example Stacktrace

unit\customizations\cloudformation\test_artifact_exporter.py:1217: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <awscli.customizations.cloudformation.artifact_exporter.Template object at 0x0000028BA010EE70>
template_path = '\\foo\\bar\\path', parent_dir = '\\'
uploader = <Mock id='2798709857248'>
resources_to_export = {'resource_type1': <Mock id='2798709858592'>, 'resource_type2': <Mock id='2798709859264'>}
metadata_to_export = [<class 'awscli.customizations.cloudformation.artifact_exporter.ServerlessRepoApplicationReadme'>, <class 'awscli.customizations.cloudformation.artifact_exporter.ServerlessRepoApplicationLicense'>]

    def __init__(self, template_path, parent_dir, uploader,
                 resources_to_export=RESOURCES_EXPORT_LIST,
                 metadata_to_export=METADATA_EXPORT_LIST):
        """
        Reads the template and makes it ready for export
        """
    
        if not (is_local_folder(parent_dir) and os.path.isabs(parent_dir)):
>           raise ValueError("parent_dir parameter must be "
                             "an absolute path to a folder {0}"
                             .format(parent_dir))
E           ValueError: parent_dir parameter must be an absolute path to a folder \

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant