fix(route53): delegation fails with public and private hosted zones with same name #30439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
aws-cdk-automation
previously requested changes
Jun 3, 2024
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
samson-keung
changed the title
samson-keung
changed the title
samson-keung
changed the title
samson-keung
changed the title
samson-keung
changed the title
samson-keung
changed the title
CrossAccountZoneDelegationRecord fails with public and private hosted zones with same name
samson-keung
changed the title
CrossAccountZoneDelegationRecord fails with public and private hosted zones with same nameCrossAccountZoneDelegationRecord fails with public and private hosted zones with same name
samson-keung
changed the title
CrossAccountZoneDelegationRecord fails with public and private hosted zones with same nameCrossAccountZoneDelegationRecord fails with public and private hosted zones with same name
samson-keung
changed the title
CrossAccountZoneDelegationRecord fails with public and private hosted zones with same name
samson-keung
changed the title
samson-keung
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-maintainer-review
aaythapa
reviewed
Jun 10, 2024
...-cdk/custom-resource-handlers/lib/aws-route53/cross-account-zone-delegation-handler/index.ts
Outdated
Show resolved
Hide resolved
...-cdk/custom-resource-handlers/test/aws-route53/cross-account-zone-delegation-handler.test.ts
Show resolved
Hide resolved
...aws-cdk-testing/framework-integ/test/aws-route53/test/integ.cross-account-zone-delegation.ts
Show resolved
Hide resolved
...hot/asset.392b3833f117607db3f72dc30f3acf726cd6b17317a3da1598e52003fd21f86b/__entrypoint__.js
Outdated
Show resolved
Hide resolved
samson-keung
force-pushed
the
filter-private-hosted-zones
branch
from
fe5c606
to
9427584
Compare
aaythapa
approved these changes
Jun 11, 2024
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mazyu36
pushed a commit
to mazyu36/aws-cdk
that referenced
this pull request
Jun 22, 2024
…ith same name (aws#30439) ### Issue # (if applicable) Closes aws#30262. ### Reason for this change Route53 does not support subdomain delegation on Private Hosted Zones ([source](https://docs.aws.amazon.com/Route53/latest/DeveloperGuide/hosted-zone-private-considerations.html#hosted-zone-private-considerations-delegating-subdomain)). `CrossAccountZoneDelegationRecord` should ignore Private Hosted Zones instead of throwing error. ### Description of changes In `CrossAccountZoneDelegationRecord` handler, filter out Private Hosted Zones. ### Description of how you validated changes Deployed a stack that uses the updated `CrossAccountZoneDelegationRecord` handler where the parent account has both public and private hosted zones with the same domain name. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This was referenced Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #30262.
Reason for this change
Route53 does not support subdomain delegation on Private Hosted Zones (source).
CrossAccountZoneDelegationRecordshould ignore Private Hosted Zones instead of throwing error.Description of changes
In
CrossAccountZoneDelegationRecordhandler, filter out Private Hosted Zones.Description of how you validated changes
Deployed a stack that uses the updated
CrossAccountZoneDelegationRecordhandler where the parent account has both public and private hosted zones with the same domain name.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license