chore(codebuild): update BuildImage classes #29616

nmussy · 2024-03-26T08:25:40Z

Issue # (if applicable)

None as far as I could tell

Overlaps with #29580

Reason for this change

Align the CodeBuild images listed by the CDK with those offered by the SDK

Description of changes

Added missing build images
- Windows 2022 was added with a warning, see PR comment
Removed @deprecated messages, see chore(codebuild): aarch64 standard 2.0 and 3.0 build images are not deprecated #29580
Updated JSDoc comments to indicate AL2023 based images, see docs
- It might be a good idea to deprecate and rename AMAZON_LINUX_2_STANDARD_3_0 to AMAZON_LINUX_2023_STANDARD_3_0, despite how the images are named. I'll leave it up to the maintainers
Added {@link} tags where missing

Description of how you validated changes

Using the codebuild:ListCuratedEnvironmentImages API command, and comparing it to the CDK.

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

nmussy · 2024-03-26T08:37:43Z

Switching to a draft for now, I need to check whether or not WINDOWS_SERVER_2022_CONTAINER is available, the docs aren't super clear about that.

If it is, I'll add an integ test here

nmussy · 2024-03-26T09:58:38Z

As the Cfn docs assert, WINDOWS_SERVER_2022_CONTAINER is not a valid Environment::Type, sort of.

When attempting to deploy aws/codebuild/windows-base:2022-1.0 with "Type": "WINDOWS_SERVER_2022_CONTAINER", Cfn returns the following error:

Windows Server 2022 not supported for on-demand compute

I've also tried deploying it with the incorrect Type, i.e. WINDOWS_SERVER_2019_CONTAINER:

AWS CodeBuild curated image aws/codebuild/windows-base:2022-1.0 is not supported for projects with environment type WINDOWS_SERVER_2019_CONTAINER and compute type BUILD_GENERAL1_MEDIUM

This matches Working with reserved capacity in AWS CodeBuild:

On-demand ﬂeets do not support Windows Server 2022.

The CDK should be able to be set this up with CfnProject:ProjectFleetProperty, but that's going to be outside the scope of this PR.

I'll open an issue to resolve this later, but in the meantime I'll mark both WindowsBuildImage.WIN_SERVER_CORE_2022_BASE_3_0 and WindowsImageType.SERVER_2022 as @deprecated, explaining the situation. This can easily be updated later on.

aws-cdk-automation · 2024-03-26T10:47:45Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 663f833
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

TheRealAmazonKendra

Thanks for adding these. I'm not sure, however, that we should be adding types that we are also immediately marking as deprecated. Can you elaborate on your thinking here?

TheRealAmazonKendra · 2024-03-27T23:33:29Z

packages/aws-cdk-lib/aws-codebuild/lib/project.ts

+ /**
+ * The WINDOWS_SERVER_2022_CONTAINER environment type
+ *
+ * @deprecated Windows Server 2022 images are not supported for on-demand compute.


I don't think we should be adding version that we are immediately marking as deprecated.

Yeah, I just want to give the user a warning that they probably won't be able to use the image as is. I thought the @deprecated was a good compromise. I can delete them here and we can add them back with #29617's PR

@TheRealAmazonKendra Nudge

aws-cdk-automation · 2024-04-18T00:09:30Z

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

nmussy · 2024-04-18T12:14:10Z

Closing in favor of #29754, which will allow an integration test of Windows 2022

### Issue # (if applicable) Closes #29617. ### Reason for this change Implementation of reserved capacity CodeBuild projects ### Description of changes * Add Fleet Construct * Add `EnvironmentType` enum * Refactor existing type strings to use the new enum * Validate that Windows 2022 build images can only be used in fleet projects Changes merged from #29616: * Added missing build images * Updated JSDoc comments to indicate AL2023 based images, see [docs](https://docs.aws.amazon.com/codebuild/latest/userguide/build-env-ref-available.html) * It might be a good idea to deprecate and rename `AMAZON_LINUX_2_STANDARD_3_0` to `AMAZON_LINUX_2023_STANDARD_3_0`, despite how the images are named. I'll leave it up to the maintainers * Added `{@link}` tags where missing ### Description of how you validated changes Unit and integ tests The images were retrieved using the [codebuild:ListCuratedEnvironmentImages](https://docs.aws.amazon.com/codebuild/latest/APIReference/API_ListCuratedEnvironmentImages.html) API command, and comparing it to the CDK. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

### Issue # (if applicable) Closes aws#29617. ### Reason for this change Implementation of reserved capacity CodeBuild projects ### Description of changes * Add Fleet Construct * Add `EnvironmentType` enum * Refactor existing type strings to use the new enum * Validate that Windows 2022 build images can only be used in fleet projects Changes merged from aws#29616: * Added missing build images * Updated JSDoc comments to indicate AL2023 based images, see [docs](https://docs.aws.amazon.com/codebuild/latest/userguide/build-env-ref-available.html) * It might be a good idea to deprecate and rename `AMAZON_LINUX_2_STANDARD_3_0` to `AMAZON_LINUX_2023_STANDARD_3_0`, despite how the images are named. I'll leave it up to the maintainers * Added `{@link}` tags where missing ### Description of how you validated changes Unit and integ tests The images were retrieved using the [codebuild:ListCuratedEnvironmentImages](https://docs.aws.amazon.com/codebuild/latest/APIReference/API_ListCuratedEnvironmentImages.html) API command, and comparing it to the CDK. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

chore(codebuild): images

80af386

aws-cdk-automation requested a review from a team March 26, 2024 08:25

github-actions bot added p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Mar 26, 2024

nmussy mentioned this pull request Mar 26, 2024

chore(codebuild): aarch64 standard 2.0 and 3.0 build images are not deprecated #29580

Merged

1 task

chore: add missing @link JSDoc tags

21af1c0

nmussy marked this pull request as draft March 26, 2024 08:35

nmussy mentioned this pull request Mar 26, 2024

CodeBuild: Fleet L2 #29617

Closed

2 tasks

nmussy added 2 commits March 26, 2024 11:15

chore: deprecate Win 2022 image

5e7e84e

chore: Windows image integ tests

663f833

nmussy marked this pull request as ready for review March 26, 2024 10:23

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 26, 2024

TheRealAmazonKendra requested changes Mar 27, 2024

View reviewed changes

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 27, 2024

This was referenced Apr 1, 2024

Monthly PR metrics report #29668

Closed

Weekly PR metrics report #29673

Closed

nmussy closed this Apr 18, 2024

nmussy mentioned this pull request Apr 18, 2024

feat(codebuild): Fleet L2 #29754

Merged

1 task

kazimanzurrashid mentioned this pull request Jun 29, 2024

[Snyk] Upgrade aws-cdk-lib from 2.144.0 to 2.145.0 kazimanzurrashid/aws-scheduler-go#821

Open

This was referenced Jun 29, 2024

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#106

Open

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#107

Open

This was referenced Jul 12, 2024

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#108

Open

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#109

Open

This was referenced Jul 19, 2024

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#110

Open

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#111

Open

NOUIY mentioned this pull request Aug 1, 2024

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#112

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(codebuild): update BuildImage classes #29616

chore(codebuild): update BuildImage classes #29616

nmussy commented Mar 26, 2024 •

edited

Loading

nmussy commented Mar 26, 2024 •

edited

Loading

nmussy commented Mar 26, 2024

aws-cdk-automation commented Mar 26, 2024

TheRealAmazonKendra left a comment

TheRealAmazonKendra Mar 27, 2024

nmussy Mar 28, 2024

nmussy Apr 4, 2024

aws-cdk-automation commented Apr 18, 2024

nmussy commented Apr 18, 2024

chore(codebuild): update BuildImage classes #29616

chore(codebuild): update BuildImage classes #29616

Conversation

nmussy commented Mar 26, 2024 • edited Loading

Issue # (if applicable)

Reason for this change

Description of changes

Description of how you validated changes

Checklist

nmussy commented Mar 26, 2024 • edited Loading

nmussy commented Mar 26, 2024

aws-cdk-automation commented Mar 26, 2024

AWS CodeBuild CI Report

TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

TheRealAmazonKendra Mar 27, 2024

Choose a reason for hiding this comment

nmussy Mar 28, 2024

Choose a reason for hiding this comment

nmussy Apr 4, 2024

Choose a reason for hiding this comment

aws-cdk-automation commented Apr 18, 2024

nmussy commented Apr 18, 2024

nmussy commented Mar 26, 2024 •

edited

Loading

nmussy commented Mar 26, 2024 •

edited

Loading