Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Tableau Extract Error #55

Merged
merged 5 commits into from
Nov 19, 2021
Merged

Conversation

lyndonbauto
Copy link
Contributor

@lyndonbauto lyndonbauto commented Nov 19, 2021

Summary

Fixing Tableau Extract Error

Description

[1] Fixed some logic around connection pooling.
[2] As discussed with Alexey, this is non-trivial to test and we will brainstorm a way to test this on Monday after GA release. For now we will rely on manual testing done by Yang, Alexey and Lyndon using Tableau.

Connection pool within TinkerPop was the connection pool that was throwing an exception.
SqlGremlinQueryExecutor held a static SqlConverter, which was given a GraphTraversalSource upon instantiation. This was then used to run Traversals as they came.
Close function would then close that GraphTraversalSource on the SqlGremlinQueryExecutor, so next query comes along and TinkerPop (library that implements GraphTraversalSource) would throw an exception saying that their connection pool is shutdown.
Close still closes the GraphTraversalSource (because it should), but now each query gets a fresh GraphTraversalSource to work off of, and it is regenerated if it is closed, then invoked again

Related Issue

https://bitquill.atlassian.net/browse/AN-879

Additional Reviewers

@birschick-bq
@lyndonb-bq
@xiazcy
@simonz-bq
@alexey-temnikov
@kylepbit

@lyndonbauto lyndonbauto added this to the Neptune JDBC Driver GA milestone Nov 19, 2021
@lyndonbauto lyndonbauto requested a review from a team November 19, 2021 22:25
@lyndonbauto lyndonbauto self-assigned this Nov 19, 2021
@lyndonbauto lyndonbauto added this to In progress in Amazon Neptune JDBC Project GA via automation Nov 19, 2021
@lyndonbauto lyndonbauto linked an issue Nov 19, 2021 that may be closed by this pull request
@lyndonbauto lyndonbauto merged commit e34c576 into develop Nov 19, 2021
Amazon Neptune JDBC Project GA automation moved this from In progress to Done Nov 19, 2021
@lyndonbauto lyndonbauto deleted the lyndon/AN-879-fix-extract-error branch November 19, 2021 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

[BUG] Tableau 2021.3 Extract feature does not work
3 participants