Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Miscellaneous Query Issues from Bug Bash #51

Merged
merged 5 commits into from
Nov 19, 2021
Merged

Fix for Miscellaneous Query Issues from Bug Bash #51

merged 5 commits into from
Nov 19, 2021

Conversation

lyndonbauto
Copy link
Contributor

Summary

Fix for Miscellaneous Query Issues from Bug Bash

Description

@lyndonbauto lyndonbauto added this to the Neptune JDBC Driver GA milestone Nov 18, 2021
@lyndonbauto lyndonbauto requested a review from a team November 18, 2021 23:54
@lyndonbauto lyndonbauto self-assigned this Nov 18, 2021
@lyndonbauto lyndonbauto added this to In progress in Amazon Neptune JDBC Project GA via automation Nov 18, 2021
@lyndonbauto lyndonbauto linked an issue Nov 18, 2021 that may be closed by this pull request
[BUG] SELECT query issues in DBVisualizer #41
Closed
kylepbit
kylepbit reviewed Nov 19, 2021
View reviewed changes
Copy link
Contributor

@kylepbit kylepbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you've fixed 3 distinct cases, but there is only one additional test case. We should have at least 3 test cases added here, likely many more, to cover off the cases that have been fixed.

@lyndonbauto
Copy link
Contributor Author

lyndonbauto commented Nov 19, 2021 •
edited
Loading

@kylepbit

I think you've fixed 3 distinct cases, but there is only one additional test case. We should have at least 3 test cases added here, likely many more, to cover off the cases that have been fixed.

Agreed - I will be adding many tests over time, I was just focusing on these specific issues in this ticket.

@lyndonbauto lyndonbauto merged commit 12af8ba into develop Nov 19, 2021
@lyndonbauto lyndonbauto deleted the lyndon/AN-866-query-issues branch November 19, 2021 21:42
Amazon Neptune JDBC Project GA automation moved this from In progress to Done Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexey-temnikov alexey-temnikov alexey-temnikov left review comments

@kylepbit kylepbit kylepbit left review comments

@xiazcy xiazcy xiazcy approved these changes

Assignees

@lyndonbauto lyndonbauto

Labels
None yet
Projects
No open projects
Amazon Neptune JDBC Project GA
  
Done
Milestone
Neptune JDBC Driver GA
Development

Successfully merging this pull request may close these issues.

[BUG] SELECT query issues in DBVisualizer
4 participants
@lyndonbauto @alexey-temnikov @kylepbit @xiazcy