Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Catalog support #49

Merged
merged 3 commits into from
Nov 19, 2021
Merged

Remove Catalog support #49

merged 3 commits into from
Nov 19, 2021

Conversation

simonz-bq
Copy link
Contributor

Summary

Remove Catalog support

Description

getCatalogTerm now returns an empty string instead of graph

I am unsure if this is the full extent of the changes required. A blanket search for methods that include the term catalog shows that the only logic that seems to have an actual function is in DatabaseMetaData describing the following:

public ResultSet getCatalogs() throws SQLException {
    LOGGER.info("Getting database catalogs.");
    return connection.getQueryExecutor().executeGetCatalogs(getConnection().createStatement());
}

This indicates to me that it's more related to a query regarding Catalogs that is a separate concept?

All tests ran and passed locally.

Related Issue

https://bitquill.atlassian.net/browse/AN-863

Additional Reviewers

@birschick-bq
@lyndonb-bq
@xiazcy
@simonz-bq
@alexey-temnikov

@lyndonbauto lyndonbauto linked an issue Nov 18, 2021 that may be closed by this pull request
@lyndonbauto lyndonbauto added this to the Neptune JDBC Driver GA milestone Nov 18, 2021
@lyndonbauto lyndonbauto added this to In progress in Amazon Neptune JDBC Project GA via automation Nov 18, 2021
@lyndonbauto
Copy link
Contributor

Did you get a chance to see if the catalog disappeared in dbvis?

@simonz-bq simonz-bq merged commit 2e4aac0 into develop Nov 19, 2021
Amazon Neptune JDBC Project GA automation moved this from In progress to Done Nov 19, 2021
@simonz-bq simonz-bq deleted the simon/AN-863 branch November 19, 2021 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

[BUG] Catalog should be reported as not supported
4 participants