AN-887 Temporarily disabling query cancellation #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonz-bq
approved these changes
Nov 18, 2021
lyndonbauto
deleted the
lyndon/temporarily-disable-query-cancellation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Temporarily disabling query cancellation
Description
Query cancellation tests have started having intermittent failures due to tight timing in GitHub actions. We have an open ticket to resolve this, as well as the constant launching and tearing down of databases. These two factors are responsible for ~90% of our test time, so I am disabling this to save about 6 minutes per build now, and will resolve both later to reduce build time and test time to something more reasonable for a client side driver.
Related Issue
https://bitquill.atlassian.net/browse/AN-887
Additional Reviewers
@birschick-bq
@lyndonb-bq
@xiazcy
@simonz-bq
@alexey-temnikov