Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update base image used #23

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

georschi
Copy link

@georschi georschi commented Apr 6, 2022

update base image used in DockerFile. public aws should be used as when the reader tries building the image on the cloud on their own account if not authenticated on dockerhub, they may be throttled based on the low daily limit of dockerhub

@athewsey
Copy link
Contributor

I think ECR public still needs users to get a docker CLI auth token right? If so, it might be useful to add this step to the README accompanying each affected sample - to make sure users who aren't familiar with the process are able to build the images as documented?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants