Terraform subnet fails to create

[peteawood]

Steps to reproduce

• Follow all steps to provision a subnet in the Using Terraform section.

Expected results

I expected to find that a subnet with the CIDR range of 10.0.1.0/24 has been created

Actual results

No subnet is created. Instead the terraform apply fails with an error unable to find a value for variable/parameter "VPCId"

This looks like an issue with case sensitivity of environment variables. The terraform variable is "VPCId" but the environment variable being set later on in the Puppet manifest file is "VPCID". When I changed the terraform variable to "VPCID" the subnet provisioned as expected.

Would propose that the fix is to change the terraform variable name as this will be in line with the Service Catalog version of this step which uses VPCID throughout for the parameter name.