Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(go/eks): refresh sample to support Amazon EKS 1.28+ #996

Merged
merged 2 commits into from
Feb 25, 2024

Conversation

guessi
Copy link
Contributor

@guessi guessi commented Feb 25, 2024

Fixes #936

Purpose of the Pull-request

  • Update support for Amazon EKS 1.28 and more attributes introduced
  • Update support for Managed Node Group
  • Update support for Managed Add-ons
  • Update test cases

Issue description

Sample script go/eks have no update for a months - HISTORY.

Before this PR, it is pointed to an outdated EKS versions (1.16/1.24), which have reached EOL for a long time, and with no github.com/cdklabs/awscdk-kubectl-go/kubectlv28/v2 imported, it is not possible to support EKS 1.22+.

eksCluster := awseks.NewCluster(stack, jsii.String("Cluster"), &awseks.ClusterProps{
Vpc: vpc,
DefaultCapacity: jsii.Number(0), // we want to manage capacity our selves
Version: awseks.KubernetesVersion_V1_16(),
})

eksCluster := awseks.NewCluster(stack, jsii.String("Cluster"), &awseks.ClusterProps{
Vpc: vpc,
DefaultCapacity: jsii.Number(0), // manage capacity with managed nodegroups later since we want to customize nodegroup
Version: awseks.KubernetesVersion_V1_24(),
// Enable alb controller to manage ingresses
AlbController: &awseks.AlbControllerOptions {
Version: awseks.AlbControllerVersion_V2_4_1(),
},
})

An update is required to get people easier to onboard to Amazon EKS with CDK.

References

Additional notes


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kaiz-io kaiz-io changed the title chore(typescript/eks): refresh sample to support Amazon EKS 1.28+ chore(go/eks): refresh sample to support Amazon EKS 1.28+ Feb 25, 2024
Copy link
Contributor

@kaiz-io kaiz-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kaiz-io kaiz-io merged commit 30348c5 into aws-samples:master Feb 25, 2024
7 checks passed
@guessi guessi deleted the golang-eks-refresh branch February 26, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-cdk-examples/typescript/eks/cluster unsupported Kubernetes version
2 participants