Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(typescript/eks): refresh sample to support Amazon EKS 1.29+ #995

Merged
merged 2 commits into from
Feb 25, 2024

Conversation

guessi
Copy link
Contributor

@guessi guessi commented Feb 25, 2024

Fixes #936

Purpose of the Pull-request

  • Update support for Amazon EKS 1.29 and more attributes introduced
  • Update support for Managed Node Group with Instance Profile support
  • Update support for Managed Add-ons
  • Update cdk.json, tsconfig.ts to keep aligned with latest CDK standards

Issue description

Sample script typescript/eks have no update for years - HISTORY.

Before this PR, it is pointed to an outdated EKS version (1.21), which have reached EOL for a long time, and with no @aws-cdk/lambda-layer-kubectl-v29 imported, it is not possible to support EKS 1.22+.

import autoscaling = require('aws-cdk-lib/aws-autoscaling');
import iam = require('aws-cdk-lib/aws-iam');
import ec2 = require('aws-cdk-lib/aws-ec2');
import eks = require('aws-cdk-lib/aws-eks');
import cdk = require('aws-cdk-lib');

An update is required to get people easier to onboard to Amazon EKS with CDK.

References

Additional notes

Required aws-cdk v2.127.0+ to support Amazon EKS 1.29+


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@guessi guessi changed the title chore(typescript/eks): refresh sample to support eks 1.29 chore(typescript/eks): refresh sample to support Amazon EKS 1.29+ Feb 25, 2024
kaiz-io
kaiz-io previously approved these changes Feb 25, 2024
Copy link
Contributor

@kaiz-io kaiz-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mergify mergify bot dismissed kaiz-io’s stale review February 25, 2024 15:04

Pull request has been modified.

Copy link
Contributor

@kaiz-io kaiz-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kaiz-io kaiz-io merged commit 1cf0f9e into aws-samples:master Feb 25, 2024
7 checks passed
@guessi guessi deleted the typescript-eks-refresh branch February 26, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-cdk-examples/typescript/eks/cluster unsupported Kubernetes version
2 participants