fix: wrong expected template for java esc example #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrArnoldPalmer
approved these changes
Dec 25, 2021
|
Thank you for contributing! Your pull request is now being automatically merged. |
its-mirus-lu
pushed a commit
to its-mirus-lu/aws-cdk-examples
that referenced
this pull request
Mar 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
com.amazonaws.cdk.examples.ECSFargateLoadBalancedStackTestis currently broken because the expected template is stale.This PR in the CDK, along with the migration of the examples to v2, made it so the
DesiredCountproperty is now not part of the template. This is the expected behavior.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.