chore: housekeeping and cleanup - gitignore, package.json #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few minor housekeeping chores to make the repo slightly easier to work with. First, standardizing on having the language-specific `.gitignore` files in the top-level language directory, rather than (inconsistently) repeated in each sample. There are a few exceptions where a local `.gitignore` is used, but it's the exception now rather than the rule. Also, the build scripts for csharp and go currently do an `npm install` command as part of the script, but there was no `package.json` in those directories. With older versions of Node (e.g., 12), this fails but doesn't exit with a non-zero status; on newer versions, this causes the whole build to fail. Lastly, a lot of the Typescript samples didn't list `aws-cdk` as either a dependency or devDependency, relying on the globally-installed CDK version. Fine on our build machines, but can cause problems in local development, especially if a recent release changes the cloud assembly schema version.
otaviomacedo
previously approved these changes
Nov 23, 2021
mergify
bot
dismissed
otaviomacedo’s stale review
Pull request has been modified.
nija-at
approved these changes
Nov 23, 2021
its-mirus-lu
pushed a commit
to its-mirus-lu/aws-cdk-examples
that referenced
this pull request
Mar 26, 2022
…s#570) A few minor housekeeping chores to make the repo slightly easier to work with. First, standardizing on having the language-specific `.gitignore` files in the top-level language directory, rather than (inconsistently) repeated in each sample. There are a few exceptions where a local `.gitignore` is used, but it's the exception now rather than the rule. Also, the build scripts for csharp and go currently do an `npm install` command as part of the script, but there was no `package.json` in those directories. With older versions of Node (e.g., 12), this fails but doesn't exit with a non-zero status; on newer versions, this causes the whole build to fail. Lastly, a lot of the Typescript samples didn't list `aws-cdk` as either a dependency or devDependency, relying on the globally-installed CDK version. Fine on our build machines, but can cause problems in local development, especially if a recent release changes the cloud assembly schema version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few minor housekeeping chores to make the repo slightly easier to work
with. First, standardizing on having the language-specific
.gitignorefiles inthe top-level language directory, rather than (inconsistently) repeated in each
sample. There are a few exceptions where a local
.gitignoreis used, but it'sthe exception now rather than the rule.
Also, the build scripts for csharp and go currently do an
npm installcommandas part of the script, but there was no
package.jsonin thosedirectories. With older versions of Node (e.g., 12), this fails but doesn't exit
with a non-zero status; on newer versions, this causes the whole build to fail.
Lastly, a lot of the Typescript samples didn't list
aws-cdkas either adependency or devDependency, relying on the globally-installed CDK version. Fine
on our build machines, but can cause problems in local development, especially if a
recent release changes the cloud assembly schema version.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.