Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Typescript npm install command and update other language package #1044

Merged
merged 2 commits into from
May 29, 2024
Merged

Fix: Typescript npm install command and update other language package #1044

merged 2 commits into from
May 29, 2024

Conversation

kaiz-io
Copy link
Contributor

@kaiz-io kaiz-io commented May 29, 2024

  • Update !typescript package.json to use at least use stable 2.0
  • If not a typescript then install the cdk cli otherwise use the cdk cli version from the ts cdk app.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

francoabregu
francoabregu approved these changes May 29, 2024
View reviewed changes
Copy link

@francoabregu francoabregu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for me

@kaiz-io kaiz-io merged commit 9d8bbff into aws-samples:main May 29, 2024
7 checks passed
@kaiz-io kaiz-io deleted the ghworkflow branch May 29, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francoabregu francoabregu francoabregu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaiz-io @francoabregu