Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger JS event on checkout success. #9735

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zutigrm
Copy link

@zutigrm zutigrm commented May 31, 2024

Fixes #

Proposed Changes:

  1. There is a JS event triggered in case of checkout failure edd_checkout_error, but not the one for successful purchase. It will be very handy to have one, to align with other plugins that need to listen to this action as well, like in our case for custom tracking.

Please do not submit PRs with minified CSS or JS files. This is managed at the time of release by the Core Team

@zutigrm
Copy link
Author

zutigrm commented May 31, 2024

Hi @cklosowski , would it be possible to have something like this?

@cklosowski
Copy link
Contributor

@zutigrm I think this has some potential but we need to do some testing and compatibility research for all different gateway situations (off-site, on-site, etc) as well as ensuring that having this trigger doesn't open up the potential for breaking the checkout processing if the Javascript that hooks into the trigger fails.

We'll look at this and do some testing to see what we feel comfortable with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants