Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ChatCompletionOptions #15

Merged
merged 2 commits into from
Dec 31, 2023
Merged

Added ChatCompletionOptions #15

merged 2 commits into from
Dec 31, 2023

Conversation

chiouyazo
Copy link

This makes it easier to set chat options, since you have all available options at hand...

This is then easily just serialized

@chiouyazo
Copy link
Author

Ref #12

@awaescher awaescher merged commit 804b152 into awaescher:main Dec 31, 2023
@awaescher
Copy link
Owner

Thanks for your contribution

@chiouyazo chiouyazo deleted the feature/ChatRequestOptions branch December 31, 2023 10:47
@chiouyazo chiouyazo mentioned this pull request Dec 31, 2023
Closed
@kescherCode
Copy link

kescherCode commented Jan 24, 2024 •
edited
Loading

It seems the Options property on ChatRequest was reverted to a string. This means that options can't be set.
Same for GenerateCompletionRequest. All cases where Options can be set should be looked over again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chiouyazo @awaescher @kescherCode