Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added grace period fields #96

Merged
merged 1 commit into from
Sep 17, 2019
Merged

Conversation

jun06t
Copy link
Contributor

@jun06t jun06t commented Sep 17, 2019

Support grace period fields.

If you choose to enable Billing Grace Period, ensure that you provide full service for the subscription throughout the grace period. You can check the grace_period_expires_date_ms field in the responseBody.Pending_renewal_info array of the receipt to determine the end of this grace period duration.

ref: https://developer.apple.com/documentation/storekit/in-app_purchase/reducing_involuntary_subscriber_churn?language=swift

Jacob already confirmed that the receipt has those new fields.

  • grace_period_expires_date
  • grace_period_expires_date_ms
  • grace_period_expires_date_pst

ref: https://www.revenuecat.com/2019/09/13/supporting-ios-billing-grace-period

@codecov
Copy link

codecov bot commented Sep 17, 2019

Codecov Report

Merging #96 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #96   +/-   ##
=======================================
  Coverage   90.36%   90.36%           
=======================================
  Files           4        4           
  Lines         249      249           
=======================================
  Hits          225      225           
  Misses         16       16           
  Partials        8        8
Impacted Files Coverage Δ
appstore/model.go 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 062102b...e895c80. Read the comment docs.

Copy link
Contributor

@kitakitabauer kitakitabauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jun06t
Copy link
Contributor Author

jun06t commented Sep 17, 2019

Thanks @kitakitabauer :-)

@jun06t jun06t merged commit 9c0e16f into awa:master Sep 17, 2019
@jun06t jun06t deleted the appstore-grace-period branch September 17, 2019 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants