Improvements for POST + Binary files support #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added improvements for: - minimal POST support - Binary files transmission (such as images) support
e-mail change
Gems
reviewed
Mar 15, 2021
|
|
||
| REQUEST_HEADERS+=("$line") | ||
| done | ||
|
|
||
| [ "$REQUEST_METHOD" = "POST" ] && read -N $POST_CONTENT_LENGTH POST_PARAMETERS |
There was a problem hiding this comment.
You might want to read here with and -r to not allow backslashes in the request body content to escape any characters
There was a problem hiding this comment.
Thank you for your contribute.
Bear in mind this project is not recommended for 'production environments' at all. This is just a proof of concept, good for prototyping, and at best, something you could use on a safe environment such as a small lab network, intranet, or some IPv4 island of your own.
That being said, i consider the 'code injection' as a pretty neat feature, not a bug. Thanks for helping pointing that out to others.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added improvements for: