Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed following issue:
Assume standard experiment with two variants
a
andb
, where variantb
is control variant and varianta
is treatment variant (usual setup is opposite --a
is control variant andb
is treatment variant).API supported setup above, but in statistics.py we assumed the first variant must be control variant -- this was hardcoded.
It should work now well. I also added test testing exactly this use-case.