Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move root logger config to CLI module #28

Merged
merged 2 commits into from
Nov 19, 2021
Merged

Move root logger config to CLI module #28

merged 2 commits into from
Nov 19, 2021

Commits on Nov 18, 2021

  1. Move logger config to CLI module 

    Previously we configured the root logger in the PMS package itself,
which would mean any code using the package as a library would get
the logging config as a side effect.

Rather than configure the root logger, which should be left to the
toplevel program, this re-scopes how we set the config to apply to
just the specific logger for the package.
    @benthorner
    benthorner committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    c843f08 View commit details
    Browse the repository at this point in the history

  2. Add __main__ CLI hook to support local dev 

    This follows the convention for typer prorams. Note the same can
also be achieved with e.g.

        python -c 'from pms.cli import main; main()'

but having it run automatically saves documenting this.
    @benthorner
    benthorner committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    a3b7857 View commit details
    Browse the repository at this point in the history