Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

refactor(setup-dev-env.sh): make the target playbook configurable #284

Merged
merged 2 commits into from
May 13, 2022

Conversation

kenji-miyake
Copy link
Contributor

@kenji-miyake kenji-miyake commented May 10, 2022

Description

Considering that users fork this repository and customize the configurations depending on their system, it is useful to change the meaning of the argument.

With this change, users can do like the following:

# Add some roles for their system
vim ~/autoware.customized/ansible/roles
vim ~/autoware.customized/ansible/playbooks/customized_playbook.yaml

# Replace the base name
sed -e "s/autoware.dev_env/autoware_customized.dev_env/g" setup-dev-env.sh

# Call the playbook
./setup-dev-env.sh customized_playbook

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kenji-miyake kenji-miyake requested a review from xmfcx May 13, 2022 00:58
@kenji-miyake
Copy link
Contributor Author

@xmfcx @esteve @yukkysaito Could you review this, please? 🙏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants