Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sim info dict #601

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Sim info dict #601

wants to merge 3 commits into from

Conversation

Bleyddyn
Copy link
Contributor

@Bleyddyn Bleyddyn commented Jul 5, 2020

Add support for saving dict's to Tub files, provided all entries are json compatible. Also add an option and support to drive and gym code to save the simulator's info dictionary (reward and done flags, cte, hit flag, position, etc.).

See issue #583 .

@blown302
Copy link
Contributor

blown302 commented Jul 5, 2020

I feel that this part is such a hub we either make is more generic accepting a output config or use the power of oop and override the run method.

@Bleyddyn
Copy link
Contributor Author

Bleyddyn commented Jul 5, 2020

@blown302 Which part do you mean? If you mean the drive code, I’ve converted it to a class with multiple methods that can be overridden, in my fork.

@blown302
Copy link
Contributor

blown302 commented Jul 5, 2020

No the gym part

@tawnkramer
Copy link
Contributor

Looks like a useful way to get data into the tubs. I like it.

@Bleyddyn
Copy link
Contributor Author

Bleyddyn commented Jul 5, 2020

No the gym part

That seems like it would be a relatively easy change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants