Added volume mappings for oauth/github/smtp config ymls #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running docker build results in the volume mapping creating a directory since the config files don't exist by default on the host machine. We need to ensure that the config files exist - perhaps by adding a new task to the Makefile that creates these files if they don't already exist. Then, they will be created when the user runs |
|
You can take a look at what #56 did |
…to config-volumes
damianhxy
approved these changes
Dec 1, 2023
|
@coderabbitai review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug where oauth, github, and smtp integrations lose their configuration when the container restarts. This PR adds volume mapping for each of the respective config.ymls so their config is preserved.