Adding SMTP Environmental Variables to Docker Compose #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
docker-compose.yml
Outdated
| @@ -55,27 +55,38 @@ services: | |||
| # - ./ssl/ssl-dhparams.pem:/etc/letsencrypt/ssl-dhparams.pem | |||
|
|
|||
| # Comment the below out to disable SSL (not recommended) | |||
| - ./nginx/app.conf:/etc/nginx/sites-enabled/webapp.conf | |||
| # - ./nginx/app.conf:/etc/nginx/sites-enabled/webapp.conf | |||
There was a problem hiding this comment.
Could you change these two lines back to default where SSL is enabled?
docker-compose.yml
Outdated
| - RESTFUL_HOST | ||
| - RESTFUL_PORT | ||
| - RESTFUL_KEY | ||
| # Edit the below to set SMTP Settings |
There was a problem hiding this comment.
These are now manipulated in .env so this line here could be misleading? Also, I think we need to update doc to reflect this .env.template change?
There was a problem hiding this comment.
I will remove this line accordingly. I will update the docs to include instructions on how to add SMTP for docker installation as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds environmental variable in docker compose to be used to populate
production.rbScreenshots of successful usage:
